Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theia-ide: Add version 1.49.100 #13274

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

goyalyashpal
Copy link
Contributor

Close: #13272

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

theia-ide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@goyalyashpal goyalyashpal changed the title theia: Add version 1.49.1 ... theia-ide: Add version 1.49.1 ... May 11, 2024
  * Note: checkver returns `1.49.1`, download-url is at `1.49.100`
    so, used in manifest is `$version00` in hopes that future versions
    will follow the same pattern.

  * Version specific download link for theia (for use in `"autoupdate"`)
    https://projects.eclipse.org/projects/ecd.theia/downloads
    -> https://download.eclipse.org/theia / ide / latest / windows

  * Dealing with NSIS pkgs: examples at https://github.com/search via:
    `user:scoopinstaller path:bucket/*.json "\"extract_dir\": \"$P"`
    https://github.com/ScoopInstaller/Extras/blob/d48d63f0bf/bucket/android-messages.json#L10-L18

  * `checkver: github` from
    https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate#special-cases

Close: ScoopInstaller#13272
@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented May 12, 2024

todo:

  • use link which can support old versions (see in code block below)
  • use hash-sha512-base64 from provided yaml file via regex (ref: hash-variables and hash-eg)
    reason for: hash coming from root upstream is obv better than calculating ad-hoc
  • use version from that file too?
    reason for: provides full version, so no $version00 i.e. 00 suffix
    reason against: github is the place linked from the theia-ide's homepage
https://download.eclipse.org/theia/ide/1.47.100/windows/TheiaIDESetup-1.47.100.exe
https://download.eclipse.org/theia/ide/latest/windows/latest.yml

@goyalyashpal goyalyashpal marked this pull request as ready for review May 12, 2024 16:49
@goyalyashpal
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

theia-ide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@goyalyashpal
Copy link
Contributor Author

uh ohw,

  • it will fail on matching hash for older versions.
  • as the hash etc info is available only for latest version...
  • though, if someone want to install an older version of theia-ide, per can use scoop install --skip to skip hash validation

so, how to proceed?

just to be clear, there's no problem in matching hash of current version; as is evident with the github-actions

Details

$ scoop download theia-ide@1.47.1
Updating Scoop...
Updating Buckets...
Scoop was updated successfully!
INFO  Downloading 'theia-ide' (1.47.1) [64bit] from svah bucket
WARN  Given version (1.47.1) does not match manifest (1.49.1)
WARN  Attempting to generate manifest for 'theia-ide' (1.47.1)
Autoupdating theia-ide
DEBUG[1715549772.06301] [$updatedProperties] = [url hash] -> D:\UserFiles\scoop\apps\scoop\current\lib\autoupdate.ps1:465:5
  ...
DEBUG[1715549772.28056] $substitutions.$baseurl                       https://download.eclipse.org/theia/ide/1.47.100/windows
  ...
DEBUG[1715549772.32169] $hashfile_url = https://download.eclipse.org/theia/ide/latest/windows/latest.yml -> D:\UserFiles\scoop\apps\scoop\current\lib\autoupdate.ps1:206:5
Searching hash for TheiaIDESetup-1.47.100.exe in https://download.eclipse.org/theia/ide/latest/windows/latest.yml
DEBUG[1715549773.86048] $regex = sha512: ([a-zA-Z0-9+\/=]{24,88}) -> D:\UserFiles\scoop\apps\scoop\current\lib\autoupdate.ps1:60:9
Found: sha512:a88a979fb1446cf463517377331ed67c78cdb9e2dec70e5d139b1b751883e2cecb20d45f060d9a1a8b30d7fb374d98ddd089e60c071cb5d8fd35819ba06a9156 using Extract Mode
Writing updated theia-ide manifest
Starting download with aria2 ...
Download: [#1e0208 4.2MiB/210MiB(1%) CN:5 DL:228KiB ETA:15m27s] 
^C

$ scoop download theia-ide@1.48.3
INFO  Downloading 'theia-ide' (1.48.3) [64bit] from svah bucket
WARN  Given version (1.48.3) does not match manifest (1.49.1)
WARN  Attempting to generate manifest for 'theia-ide' (1.48.3)
Autoupdating theia-ide
DEBUG[1715549842.13152] [$updatedProperties] = [url hash] -> D:\UserFiles\scoop\apps\scoop\current\lib\autoupdate.ps1:465:5
  ...
DEBUG[1715549842.28746] $substitutions.$baseurl                       https://download.eclipse.org/theia/ide/1.48.300/windows
  ...
DEBUG[1715549842.3241] $hashfile_url = https://download.eclipse.org/theia/ide/latest/windows/latest.yml -> D:\UserFiles\scoop\apps\scoop\current\lib\autoupdate.ps1:206:5
Searching hash for TheiaIDESetup-1.48.300.exe in https://download.eclipse.org/theia/ide/latest/windows/latest.yml
DEBUG[1715549843.78344] $regex = sha512: ([a-zA-Z0-9+\/=]{24,88}) -> D:\UserFiles\scoop\apps\scoop\current\lib\autoupdate.ps1:60:9
Found: sha512:a88a979fb1446cf463517377331ed67c78cdb9e2dec70e5d139b1b751883e2cecb20d45f060d9a1a8b30d7fb374d98ddd089e60c071cb5d8fd35819ba06a9156 using Extract Mode
Writing updated theia-ide manifest
Starting download with aria2 ...
Download: [#96bebb 304KiB/196MiB(0%) CN:5 DL:184KiB ETA:18m12s]
^C

  * Get sha512 hash with `$base64` from `latest.yml` file upstream
  * Ref: 'hash-from-text-file' & 'hash-variables' at scoop-wiki
  https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate
  * Use versioned directory for package, rather than "latest/" one
  to accomodate using some older versions too.
  * Newer versions from `jq` filter on given url's data should work:
  https://api.github.com/repos/eclipse-theia/theia/releases

  ```jq
  [ .[].tag_name[1:] | select(. >= "1.44") ] |
  group_by( .[:-1] )[] | max_by(.)
  ```
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
@niheaven niheaven changed the title theia-ide: Add version 1.49.1 ... theia-ide: Add version 1.49.100 May 15, 2024
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@goyalyashpal
Copy link
Contributor Author

oops, added . at end by mistake. should i commit --amend it?

@niheaven
Copy link
Member

Never mind.

@niheaven
Copy link
Member

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

theia-ide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@goyalyashpal goyalyashpal marked this pull request as draft May 15, 2024 11:37
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
@goyalyashpal goyalyashpal marked this pull request as ready for review May 15, 2024 13:53
bucket/theia-ide.json Outdated Show resolved Hide resolved
bucket/theia-ide.json Outdated Show resolved Hide resolved
* But force use the `mirror_id=1` i.e. (Canada) Main Download Site
  * As the "best" resolved mirror was extremely slow in my case, 
  * ... might as well be for others too
@goyalyashpal
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

theia-ide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

bucket/theia-ide.json Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@goyalyashpal
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

theia-ide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@niheaven niheaven merged commit 2bb98a9 into ScoopInstaller:master May 17, 2024
2 checks passed
@goyalyashpal goyalyashpal deleted the add-theia branch May 17, 2024 02:12
@goyalyashpal
Copy link
Contributor Author

holly molly.

  • soooo glad we used the latest//latest.yml file for checkver.
  • the version 1.49.101 landed here 😂😅 : 7a3e41d
  • the github repo is still at 1.49.1

thanks for this enlightening comment 😇🪔:

The theia project is version 1.49.1 which is a framework, when came to IDE, the version is 1.49.100.
- @ niheaven at #13274 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: theia ide
2 participants