Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-filter-repo@2.34.0: decompress error #3042

Closed
peterleif opened this issue Dec 4, 2021 · 15 comments
Closed

git-filter-repo@2.34.0: decompress error #3042

peterleif opened this issue Dec 4, 2021 · 15 comments
Labels
help-wanted Extra attention is needed

Comments

@peterleif
Copy link

Console result

Installing 'git-filter-repo' (2.34.0) [64bit]
Loading v2.34.0.zip from cache
Checking hash of v2.34.0.zip ... ok.
Extracting v2.34.0.zip ... ERROR Exit code was 2!
Failed to extract files from C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip.
Log file:
  ~\scoop\apps\git-filter-repo\2.34.0\7zip.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Main/issues/new?title=git-filter-repo%402.34.0%3a+decompress+error

Log file


7-Zip 21.06 (x64) : Copyright (c) 1999-2021 Igor Pavlov : 2021-11-24

Scanning the drive for archives:
1 file, 190207 bytes (186 KiB)

Extracting archive: C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip
--
Path = C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip
Type = zip
Physical Size = 190207
Comment = 235fed326910a90b3322bc535d643a9003f8d7e1


Sub items Errors: 2

Archives with Errors: 1

Sub items Errors: 2

There is no problem extracting cached zip archive file using windows system decompressor.

A similar issue is here #2290

@peterleif
Copy link
Author

peterleif commented Dec 4, 2021

Files that are failing to decompress are

These files are originally symbolic link, but they are substituted with text files in the zip archive.

Error may be related to some bugs in Github or 7-zip.

@phanirithvij
Copy link
Contributor

phanirithvij commented Dec 17, 2021

@peterleif can you still reproduce this now, after ScoopInstaller/Scoop#4569 (comment) landed?
Edit: Nvm it still hasn't been merged to master
Can be verified using scoop config SCOOP_BRANCH develop #2961 (comment) or wait for develop to get merged in the coming week.

@peterleif
Copy link
Author

I changed SCOOP_BRANCH to develop and now I can see the error message from 7-zip.

7-Zip 21.06 (x64) : Copyright (c) 1999-2021 Igor Pavlov : 2021-11-24

Scanning the drive for archives:
1 file, 190207 bytes (186 KiB)

Extracting archive: C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip
--
Path = C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip
Type = zip
Physical Size = 190207
Comment = 235fed326910a90b3322bc535d643a9003f8d7e1


Sub items Errors: 2

Archives with Errors: 1

Sub items Errors: 2

ERROR: Cannot create symbolic link : クライアントは要求された特権を保有していません。 : C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\git-filter-repo-2.34.0\contrib\filter-repo-demos\filter-branch-ish
ERROR: Cannot create symbolic link : クライアントは要求された特権を保有していません。 : C:\Users\peter\scoop\apps\git-filter-repo\2.34.0\git-filter-repo-2.34.0\git_filter_repo.py

The error message is Japanese (I'm using Japanese environment), which says "The client does not have the requested permission."
It seems that 7-zip tries to decompress symbolic link as symbolic link even on Windows (system decompressor decompresses it as a text file).

@rdbisme
Copy link
Contributor

rdbisme commented Jan 11, 2022

Hello I just tested but 8b8da66 does not fix the problem apparently...

@rashil2000
Copy link
Member

What is the error?

@rdbisme
Copy link
Contributor

rdbisme commented Jan 11, 2022

$ scoop update git-filter-repo
git-filter-repo: 2.33.0 -> 2.34.0
Updating 1 outdated app:
Updating 'git-filter-repo' (2.33.0 -> 2.34.0) [64bit]
Downloading new version
Loading v2.34.0.zip from cache
Checking hash of v2.34.0.zip ... ok.
Uninstalling 'git-filter-repo' (2.33.0)
WARN  Shim for 'git-filter-repo' is missing. Skipping.
Installing 'git-filter-repo' (2.34.0) [64bit] [main]
WARN  By installing you accept following license: MIT (https://spdx.org/licenses/MIT.html)
Loading v2.34.0.zip from cache
Extracting v2.34.0.zip ... ERROR Exit code was 2!
ERROR Failed to extract files from C:\Users\rdibattista\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip.
Log file:
  ~\scoop\apps\git-filter-repo\2.34.0\7zip.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Main/issues/new?title=git-filter-repo%402.34.0%3a+Decompress+error&body=Failed+to+extract+files+from+C%3a%5cUsers%5crdibattista%5cscoop%5capps%5cgit-filter-repo%5c2.34.0%5cv2.34.0.zip.%0aLog+file%3a%0a++%7e%5cscoop%5capps%5cgit-filter-repo%5c2.34.0%5c7zip.log
ERROR This application failed to update: git-filter-repo
 

And the log:

7-Zip 21.07 (x64) : Copyright (c) 1999-2021 Igor Pavlov : 2021-12-26

Scanning the drive for archives:
1 file, 190207 bytes (186 KiB)

Extracting archive: C:\Users\rdibattista\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip
--
Path = C:\Users\rdibattista\scoop\apps\git-filter-repo\2.34.0\v2.34.0.zip
Type = zip
Physical Size = 190207
Comment = 235fed326910a90b3322bc535d643a9003f8d7e1


Sub items Errors: 2

Archives with Errors: 1

Sub items Errors: 2

@rashil2000
Copy link
Member

You are using a fork of Scoop. Please report the bug there.

@peterleif
Copy link
Author

Same here. 8b8da66 does not solve the issue.
The error message is the same as what I uploaded previously.

Since the error occurs in zip extraction, I think the changes in 8b8da66 is not relevant to this specific issue.

@rdbisme
Copy link
Contributor

rdbisme commented Jan 12, 2022

@rashil2000 is the second time I get "you are using a fork, ask there" for an issue that is actually meant to be here. I don't understand why.

Anyway this issue must be reopened.

@rashil2000
Copy link
Member

@issaclin32 @HUMORCE @niheaven are you able to reproduce this bug? I can't.

@issaclin32
Copy link
Member

issaclin32 commented Jan 12, 2022

Cannot reproduce either.
My 7-zip log shows the same content, except that there are no errors.
I don't think outdated 7-zip will cause problems on .zip, and the hash is correct, so maybe it is due to "no empty space" or some HDD / RAM errors?

@rdbisme You probably need to run 7z t -bb3 (SCOOP_DIR)\cache\git-filter-repo#2.34.0#https_github.com_newren_git-filter-repo_archive_v2.34.0.zip, to see what is going on.

@peterleif
Copy link
Author

peterleif commented Jan 12, 2022

I am not @rdbisme but I tried it.
7z t -bb3 (path_to_zip) shows no error and 7z e -bb3 (path_to_zip) shows the error "The client does not have the requested permission."

I also tried extracting in a shell with the administrative privilege, and the extraction succeeded.

By default, Windows does not allow creation of symbolic links by a normal user.
@rashil2000 @issaclin32 did you changed the setting or did you run 7z in a shell with the administrative privilege?

@HUMORCE
Copy link
Member

HUMORCE commented Jan 12, 2022

@HUMORCE HUMORCE reopened this Jan 12, 2022
@rashil2000
Copy link
Member

I have transferred it to Scoop core. Let's combine and track them there.

See ScoopInstaller/Scoop#4647

@niheaven
Copy link
Member

I tried in PS5 and PS7 with latest 'delelop' branch, and cannot reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants