Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some tests on linux #2153

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Fix some tests on linux #2153

merged 2 commits into from
Apr 4, 2018

Conversation

leonyu
Copy link
Contributor

@leonyu leonyu commented Mar 25, 2018

Fix some test on Linux.

  • Currently Get-Content on Linux doesn't support -Encoding , thus cannot read file as Byte. It is still possible to read the test using .NET functionality.
  • Adjust path to use join-path in another file

@leonyu
Copy link
Contributor Author

leonyu commented Mar 25, 2018 •
edited
Loading

Also I am not sure if AppVeyor supports Linux with PowerShell, if not, it is fairly easy to use CircleCI, a Docker-based cloud CI, to do Linux CI by pulling microsoft/powershell

@r15ch13 r15ch13 merged commit 71da515 into ScoopInstaller:master Apr 4, 2018
@leonyu leonyu deleted the fix_some_tests_on_linux branch April 5, 2018 03:56
@leonyu leonyu mentioned this pull request Jul 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasa rasa rasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leonyu @rasa @r15ch13