-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Checkver] Support skipping up to date manifests #2624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but some small changes are required 👍
bin/checkver.ps1
Outdated
continue | ||
} | ||
|
||
write-host "$ver" -f darkred -nonewline | ||
write-host " (scoop version is $expected_ver)" -NoNewline | ||
$update_available = (compare_versions $expected_ver $ver) -eq -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$updateAvailable
or $UpdateAvailable
or $update_available
. Combining snake_case and camelCase looks awkward 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong regex for rename all occurancies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there this $update_available
check? You already know, there is version mismatch if you use $ver -eq $expected_ver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, it's pretty much the cause of automated downgrades, now that I think about it.
compare_versions
should be used instead of $ver -eq $expected_ver
, I guess.
Anything else need to be added / fixed. Do you need any help with wiki or something else? |
Further testing is welcomed and required i think.
How it look: