Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buckets: Move function into lib from lib-exec #3062

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

Ash258
Copy link
Contributor

@Ash258 Ash258 commented Feb 1, 2019

There is no reason to have it inside lib-exec since, it's all internal functions, which could be used inside other code

  • Remove list_buckets function.
    • It's only function, which call buckets

lib-exec scripts should be slimmed as possible, as they are only code runners with some validation

There is no reason to have it inside lib-exec since, it's all internal functions, which could be used inside other code

lib-exec scripts should be slimmed as possible, as they are only code runners with some validation
@r15ch13 r15ch13 merged commit ec23179 into ScoopInstaller:master Feb 1, 2019
@Ash258 Ash258 deleted the buckets branch February 2, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants