PowerShell: Update requirement to version 5 #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niheaven
changed the title
rasa
approved these changes
Apr 17, 2019
|
How about suggesting to install pwsh too as an alternative? |
r15ch13
reviewed
Apr 17, 2019
|
Good idea! I'll add it later. |
|
Suggesting pwsh is nice, but how would updates be handled? Problem which i am thinkig of today: When you install pwsh using scoop and you need to update pwsh. How do you do this? Because uninstallation will try to remove pwsh (uninstall old) and fail due to it is use. |
|
I don't suggest install pwsh using scoop, since it will not be registered in the system, and won't be found by many apps. And in readme of scoop, pwsh is a prerequisite of installation, new user shouldn't install it by scoop, so it's ok, I think. |
niheaven
force-pushed
the
update-powershell
branch
from
5284602
to
30c9227
Compare
r15ch13
added a commit
that referenced
this pull request
May 12, 2019
- The main bucket of Scoop has been separated to https://github.com/ScoopInstaller/Main - Requires PowerShell 5 and newer #3330 - Improve and refactor decompression functions #3204 #3409 #3411 - Move scoop config from `~\.scoop` to `~\.config\scoop\config.json` #3242 - Add `scoop hold` and `scoop unhold` for excluding programs from updates #3444 - Refactored some Core functions #3314 #3416 - Small fix for starting processes on Windows 7 #3415 Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Chawye Hsu <h404bi@outlook.com> Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3325