Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(decompress): Add 'ExtractDir' to 'Expand-...' functions #3466

Merged
merged 2 commits into from
May 16, 2019

Conversation

niheaven
Copy link
Member

Move $extract_dir and $extract_to to decompress.ps1 so as to not run robocopy so many times.

Tested on

  • 'slack'(w/ extract_dir, 7z/nupkg)
  • 'brackets'(w/ extract_dir, msiexec/lessmsi)
  • 'atom-portable'(w/ extract_dir and extract_to)
  • 'irfanview'(w/ multi extract_to)
  • 'unxutils'(w/ extract_to overwrite)

@Ash258
Copy link
Contributor

Ash258 commented May 16, 2019

LGTM by fast static review. Will test in few hours.

@niheaven
Copy link
Member Author

Tested 'TrimEnd', msiexec and lessmsi need to trim \, others needn't.

Also fix nested 7z extraction.

All done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants