Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bin): Checkhashes downloading twice when architecture properties does hot have url property #3479

Merged
merged 1 commit into from
May 26, 2019
Merged

fix(bin): Checkhashes downloading twice when architecture properties does hot have url property #3479

merged 1 commit into from
May 26, 2019

Conversation

Ash258
Copy link
Contributor

@Ash258 Ash258 commented May 26, 2019

When there were url and architecture properties. Architecture properties were considered first, which lead to this:

  1. arch_specific 64bit => none, fallback to url property on root
  2. arch_specific 32bit => none, fallback to url property on root
  3. Resulted in one URL downloaded twice

Before:

image

After:

image

@r15ch13 r15ch13 merged commit 1b84fe0 into ScoopInstaller:develop May 26, 2019
@Ash258 Ash258 deleted the hashes branch May 26, 2019 11:53
r15ch13 pushed a commit that referenced this pull request Jun 24, 2019
@Ash258 @r15ch13
fix(bin): Checkhashes downloading twice when architecture properties …
e12a7da 
…does hot have url property (#3479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ash258 @r15ch13