Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error matching bat and cmd file #3529

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fix error matching bat and cmd file #3529

merged 2 commits into from
Jun 24, 2019

Conversation

huiyifyj
Copy link
Contributor

Ash258
Ash258 suggested changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.editorconfig Outdated Show resolved Hide resolved
@chawyehsu
Copy link
Member

Please rebase it to the develop branch.

@huiyifyj huiyifyj changed the base branch from master to develop June 23, 2019 14:37
@huiyifyj huiyifyj changed the base branch from develop to master June 23, 2019 14:43
@huiyifyj huiyifyj changed the base branch from master to develop June 23, 2019 14:45
@huiyifyj
Copy link
Contributor Author

Please rebase it to the develop branch.

rebase branch with tiny mistake. 😥

Do it. 👌

@r15ch13 r15ch13 merged commit b71b507 into ScoopInstaller:develop Jun 24, 2019
Ash258 pushed a commit to Ash258/Scoop-Core that referenced this pull request Aug 31, 2019
@huiyifyj @Ash258
fix(editorconfig): add missing } to bat/cmd regex (ScoopInstaller#3529)
b7f0747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasa rasa rasa approved these changes

@Ash258 Ash258 Ash258 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@huiyifyj @chawyehsu @rasa @Ash258 @r15ch13