Escape dir vars when calling COMSPEC cmds #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMSPEC commands fail when called with unescaped directory arguments which contain white spaces (typically a compound user name). This fixes ScoopInstaller#1781 [0] downstream in the "extra" bucket. [0] ScoopInstaller/Extras#1781 Signed-off-by: Niklas H. <Typhoon.CommanderCool@gmail.com>
|
Add this to PR description: - Closes lukesampson/scoop-extras#2389
- Closes #2801 |
Done |
|
You need to make it strict otherwise it will not automatically close when merged -lukesampson/scoop-extras#1781
-lukesampson/scoop-extras#2389
-#2801
+- Closes lukesampson/scoop-extras#1781
+- Closes lukesampson/scoop-extras#2389
+- Closes #2801 |
|
Sorry, didn't know! |
Ash258
pushed a commit
to Ash258/Scoop-Core
that referenced
this pull request
Aug 31, 2019
…staller#3538) COMSPEC commands fail when called with unescaped directory arguments which contain white spaces (typically a compound user name). - Closes ScoopInstaller/Extras#1781 - Closes ScoopInstaller/Extras#2389 - Closes ScoopInstaller#2801 Signed-off-by: Niklas H. <Typhoon.CommanderCool@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMSPEC commands fail when called with unescaped directory arguments which contain white spaces (typically a compound user name).
This PR