Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix help collision #3564

Merged
merged 1 commit into from
Jul 18, 2019
Merged

fix help collision #3564

merged 1 commit into from
Jul 18, 2019

Conversation

ocitrev
Copy link
Contributor

@ocitrev ocitrev commented Jul 18, 2019

Fix command scoop help when alias help is declared.

When a user has an alias named help, scoop help does not work anymore.
This PR renames the function help to scoop_help to prevent collision with a user alias.

Steps to reproduce:

PS> Set-Alias help Get-Help
PS> scoop help install
help : The term 'local:help' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At C:\Users\Eric\scoop\apps\scoop\current\libexec\scoop-help.ps1:16 char:13
+     $help = help $file
+             ~~~~
+ CategoryInfo          : ObjectNotFound: (local:help:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

Usage: scoop install <app> [options]

@r15ch13 r15ch13 changed the base branch from master to develop July 18, 2019 16:31
@r15ch13 r15ch13 merged commit 78d2ff7 into ScoopInstaller:develop Jul 18, 2019
@ocitrev ocitrev deleted the fix-help branch July 18, 2019 21:23
Ash258 pushed a commit to Ash258/Scoop-Core that referenced this pull request Aug 31, 2019
When a user has an alias named `help`, the `scoop help` command does not work anymore.
To prevent collision with a user alias the function is renamed from `help` to `scoop_help`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants