fix(config): Fix set_config bugs
#3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as: ScoopInstaller#3680 but in develop branch --> --- - `Out-Null` is slow, casting to `[void]` or assigning to `$null` is much faster - Add parameter names instead of relying on position - Do not allow null or empty string for `$name` - function would previously thow an error if that occured, and it doesn't make sense to allow for it - if `$scoopConfig` was `$null` and `$value` was a boolean-string ("True"/"False") it would previously not have been converted to a bool-type and saved in the JSON as a string-value instead. Fixed by moving the bool-conversion logic outside of the unrelated if-statement
r15ch13
reviewed
Oct 12, 2019
As per discussion in ScoopInstaller#3681 - in the interest of readability
rashil2000
changed the title
niheaven
approved these changes
Feb 10, 2022
niheaven
changed the title
set_config bugs
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: #3680 but in develop branch -->
Out-Nullis slow, casting to[void]or assigning to$nullis much faster$name- function would previously thow an error if that occured, and it doesn't make sense to allow for it$scoopConfigwas$nulland$valuewas a boolean-string ("True"/"False") it would previously not have been converted to a bool-type and saved in the JSON as a string-value instead. Fixed by moving the bool-conversion logic outside of the unrelated if-statement