feat(shim): Add another alternative shim written in rust #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the only shim that (kinda) works with TortoiseGit for me: it's detecting Git fine and I'm even able to do stuff with it. Unfortunately, for every TortoiseGit operation I get a lot of flashing console windows, since it needs to run a bunch of Git commands. |
|
Could you upload a VirusTotal report for this exe? |
There seems to be an issue with the exe file: https://www.virustotal.com/gui/file/03037ad0dffc96a468197aa4a7d3f040eef271fbd2c79337716436d9b649eec3/detection |
niheaven
pushed a commit
that referenced
this pull request
Dec 1, 2021
…)" This reverts commit 5ad8c76.
rasa
pushed a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zoritle/rshim
C# version didn't handle Ctrl event properly.
C version randomly crashed.
C++ version =creating infinite processes recursively until OOM.
This version is written in rust that is safe and performant, hopefully eliminate all problems above.
see #3634
VirusTotal: Report