Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scoop-prefix): remove unused imports and functions #4494

Conversation

pratikpc
Copy link
Contributor

@pratikpc pratikpc commented Nov 4, 2021

Unused imports removed:-

  1. manifest.ps1
  2. buckets.ps1

Unused function removed:-

  1. reset_aliases:- We do not use aliases here.

Load when required

  1. help needs to be loaded only when app is not specified
  2. core needs to be loaded only when app is specified

Gains:-

  1. Improved speed.

…quired

Unused imports removed:-
1. manifest.ps1
2. buckets.ps1

Unused function removed:-
1. reset_aliases:- We do not use aliases here.

Load when required
1. help needs to be loaded only when app is not specified
2. core needs to be loaded only when app is specified

Gains:-
1. Improved speed.
@niheaven niheaven changed the title feat(scoop-prefix): remove unused imports and functions. Load when required feat(scoop-prefix): remove unused imports and functions Nov 5, 2021
@niheaven niheaven merged commit 458ec90 into ScoopInstaller:develop Nov 5, 2021
@pratikpc pratikpc deleted the scoop-prefix-remove-unused-import-function-manifests branch November 5, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants