Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(shim): Add another alternative shim written in rust (#4229)" #4553

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Dec 1, 2021

Close #4551

This reverts commit 5ad8c76.

@niheaven niheaven changed the title Revert "feat(shim): Add another alternative shim written in rust (#42… Revert "feat(shim): Add another alternative shim written in rust (#4229)" Dec 1, 2021
@rasa
Copy link
Member

rasa commented Dec 1, 2021

But this doesn't remove the shim from the user's system, or even run scoop reset to unwind it

@rasa rasa merged commit d021438 into master Dec 1, 2021
@rashil2000
Copy link
Member

Given that the shim was added only recently, not many people might have set it. And scoop update should remove it.

@rashil2000 rashil2000 deleted the remove-rshim branch December 1, 2021 16:47
@rashil2000 rashil2000 restored the remove-rshim branch December 6, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malware detection in C:\Users\sgarcia\scoop\apps\scoop\current\supporting\shims\rshim\shim.exe
4 participants