Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(manifest): Fix manifests validation #4620

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 5, 2022

Description

Skip manifests test since there is no bucket directory in scoop core.

bin\test.ps1 is now an alias to test\bin\test.ps1

How Has This Been Tested?

Before:
image

After:
image
image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven
Copy link
Member Author

niheaven commented Jan 5, 2022

For Scoop-Bucket.Tests.ps1 file in bucket repos, further investigation is needed.

Copy link
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I haven't tested)

@niheaven
Copy link
Member Author

niheaven commented Jan 7, 2022

I'll merge this and may add a Tests bucket in the organization which is used for features testing that use develop branch as its backend. When collaborators tend to add some new features to scoop core, they can add testing manifests in this repo (e.g., testing manifests in #3502).

@niheaven niheaven merged commit c864f68 into develop Jan 7, 2022
@niheaven niheaven deleted the fix-manifest-test branch January 7, 2022 05:33
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants