fix(config): Allow scoop config use Unicode characters
#4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashil2000
approved these changes
Jan 7, 2022
chawyehsu
added a commit
to chawyehsu/scoop
that referenced
this pull request
Jan 11, 2022
This patch forces Scoop's config.json and aria2's input-file are saved and used with the UTF8 encoding to support non-ASCII characters like CJK. A previous patch ScoopInstaller#4631 was applied to fix the encoding of Scoop's config file. But it does not work well, it replaced the 'ASCII' encoding of function `Set-Content` with the 'Default' encoding. This does not work in PowerShell 5 since the default encoding under PowerShell 5 [1] corresponds to the system's active code page (usually ANSI). This patch introduces a `Set-ContentUTF8NoBOM` function. It's a wrapper of the `Out-File` function using the 'UTF8NoBOM' encoding and .NET's `WriteAllText` function which saves file in a BOMless UTF8 encoding [2]. When Scoop is executed under PowerShell 6+, the native PowerShell `Out-File` function will be used, otherwise the .NET's one will be used. Also with this patch, now aria2 reads the correct `cachedir` from Scoop's config file, and consumes the input-file which is also utf8 encoded. By changing console's encoding to utf8 temporarily, aria2's output can display correctly even it contains non-ASCII. Fixes ScoopInstaller#4629 [1]: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/set-content?view=powershell-5.1 [2]: https://docs.microsoft.com/en-us/dotnet/api/system.io.file.writealltext Signed-off-by: Chawye Hsu <chawyehsu@hotmail.com>
3 tasks
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Save config file with
Defaultencoding.Motivation and Context
Relates to #4629
If users use Unicode characters in
scoop configcommand, these characters will not be saved to config fileHow Has This Been Tested?
Before:
After:
Checklist: