fix(depends): Keep bucket in 'Get-Dependency()' #4673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4638 changes some logic of installing and updating, and
Get-Dependency()
trimmed bucket from app's name (e.g.,versions/7zip-zstd
->7zip-zstd
), this introduces some bug when user installs some apps that duplicated with known buckets.This PR keeps bucket name with app name while resolving dependencies, so the installation won't be confused.
Besides, #4638 may breaks #4595, and no URL bug is fixed again by allow $null in
Test-xxxRequirement()
functions.Motivation and Context
Closes #4662
How Has This Been Tested?
Checklist: