Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(depends): Keep bucket in 'Get-Dependency()' #4673

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 18, 2022

Description

#4638 changes some logic of installing and updating, and Get-Dependency() trimmed bucket from app's name (e.g., versions/7zip-zstd -> 7zip-zstd), this introduces some bug when user installs some apps that duplicated with known buckets.

This PR keeps bucket name with app name while resolving dependencies, so the installation won't be confused.

Besides, #4638 may breaks #4595, and no URL bug is fixed again by allow $null in Test-xxxRequirement() functions.

Motivation and Context

Closes #4662

How Has This Been Tested?

image
image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@HUMORCE
Copy link
Member

HUMORCE commented Jan 19, 2022

fixed after this PR.

PS C:\Users\HUMOR\scoop\buckets> scoop config SCOOP_BRANCH
fix-depends-bucket
PS C:\Users\HUMOR> cd .\scoop\buckets\
PS C:\Users\HUMOR\scoop\buckets> cp main new -Recurse
PS C:\Users\HUMOR\scoop\buckets> scoop install new/x264
Installing 'x264' (3081) [64bit]
x264-r3081-19856cc.exe (17.3 MB) [============================================================================] 100%
Checking hash of x264-r3081-19856cc.exe ... ok.
Linking ~\scoop\apps\x264\current => ~\scoop\apps\x264\3081
Creating shim for 'x264'.
'x264' (3081) was installed successfully!
PS C:\Users\HUMOR\scoop\buckets> scoop list x264
Installed apps matching 'x264':

  x264 3081 [new]

PS C:\Users\HUMOR\scoop\buckets> code .\new\bucket\x264.json
PS C:\Users\HUMOR\scoop\buckets> scoop update x264
x264: 3081 -> 9999
Updating one outdated app:
Updating 'x264' (3081 -> 9999)
Downloading new version
x264-r3081-19856cc.exe (17.3 MB) [============================================================================] 100%
Checking hash of x264-r3081-19856cc.exe ... ok.
Uninstalling 'x264' (3081)
Removing shim 'x264.exe'.
Removing shim 'x264.shim'.
Unlinking ~\scoop\apps\x264\current
Installing 'x264' (9999) [64bit]
Loading x264-r3081-19856cc.exe from cache
Linking ~\scoop\apps\x264\current => ~\scoop\apps\x264\9999
Creating shim for 'x264'.
'x264' (9999) was installed successfully!
PS C:\Users\HUMOR\scoop\buckets> scoop list x264
Installed apps matching 'x264':

  x264 9999 [new]

PS C:\Users\HUMOR\scoop\buckets> scoop uninstall x264
Uninstalling 'x264' (19999).
Removing shim 'x264.exe'.
Removing shim 'x264.shim'.
Unlinking ~\scoop\apps\x264\current
Removing older version (3081).
Removing older version (9999).
'x264' was uninstalled.
PS C:\Users\HUMOR\scoop\buckets> scoop install x264
Installing 'x264' (3081) [64bit]
Loading x264-r3081-19856cc.exe from cache
Checking hash of x264-r3081-19856cc.exe ... ok.
Linking ~\scoop\apps\x264\current => ~\scoop\apps\x264\3081
Creating shim for 'x264'.
'x264' (3081) was installed successfully!
PS C:\Users\HUMOR\scoop\buckets> scoop list x264
Installed apps matching 'x264':

  x264 3081 [main]

@niheaven niheaven merged commit d023e6c into develop Jan 19, 2022
@niheaven niheaven deleted the fix-depends-bucket branch January 19, 2022 14:06
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants