Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rmdir): Use 'Remove-Item' instead of 'rmdir' #4691

Merged
merged 2 commits into from
Jan 25, 2022
Merged

refactor(rmdir): Use 'Remove-Item' instead of 'rmdir' #4691

merged 2 commits into from
Jan 25, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 25, 2022 •
edited
Loading

Description

  • rmdir -> Remove-Item -Force
  • rmdir /s -> Remove-Item -Recurse -Force
  • del -> Remove-Item -Force
  • Style lib/psmodules.ps1

Motivation and Context

Relates to #4687 (comment)

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven niheaven merged commit 3f4c191 into develop Jan 25, 2022
@niheaven niheaven deleted the fix-comspec branch January 25, 2022 18:34
@niheaven niheaven mentioned this pull request Mar 2, 2022
Merged
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@niheaven @se35710
refactor(rmdir): Use 'Remove-Item' instead of 'rmdir' (ScoopInstaller…
28ca55c 
…#4691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niheaven @rashil2000