fix(shim): Fix shim when app path has white spaces #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should wait for more people to test this. I have used multiple custom shims with whitespaces, and they work. |
|
Hey @rashil2000 how can i test it? |
|
Simpler method would be: |
|
Tested it with some shims. Seems to work good. |
3 tasks
|
@rashil2000 Does this break something? |
|
I don't think so, but I have been unable to reproduce the original issue for a long time. My $Env:SCOOP points to 'E:\Scoop Stuff' and all my shims work 😢 |
|
Aha, I could not reproduce, too... Maybe some Env setting or OS version related? If it is harmless for other code or users, merging this tends to be not a bad choice. |
rashil2000
approved these changes
Feb 26, 2022
|
Are we making a release? |
|
Yes, after merging this, I'll make a release. |
This was referenced Mar 2, 2022
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enclose app path with double quotes to fix bug while app path has white spaces.
Motivation and Context
Closes #4728
How Has This Been Tested?
Only occurred in exe shims, hard to test.
Checklist: