Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly quote $@ in sh->ps1 shims #4809

Merged
merged 1 commit into from
Mar 14, 2022
Merged

fix: Correctly quote $@ in sh->ps1 shims #4809

merged 1 commit into from
Mar 14, 2022

Conversation

e6c31d
Copy link
Contributor

@e6c31d e6c31d commented Mar 13, 2022

Description

Correctly quote $@ in sh->ps1 shims

Motivation and Context

Closes #4808

How Has This Been Tested?

  1. Made the change locally to ~/scoop/apps/scoop/current
  2. Run scoop update
  3. Verified ~/scoop/shims/scoop is updated correctly
  4. Run scoop update '*' from git bash, which succeeded.

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@rashil2000
Copy link
Member

Hey @e6c31d, thanks for tracking down the bug!

For a contribution, you need to open the PR against the develop branch. And also update the changelog.

@e6c31d e6c31d changed the base branch from master to develop March 13, 2022 06:08
@e6c31d
Copy link
Contributor Author

e6c31d commented Mar 13, 2022

@rashil2000 Done.

@rashil2000 rashil2000 merged commit 635ae17 into ScoopInstaller:develop Mar 14, 2022
@chawyehsu chawyehsu mentioned this pull request Mar 23, 2022
Merged
@niheaven niheaven mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

@niheaven niheaven Awaiting requested review from niheaven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] '*' not escaped correctly from git bash
2 participants
@e6c31d @rashil2000