fix(core): Use Invoke-Command instead of Invoke-Expression

[niheaven]

Description

Get rid of Invoke-Expression that may cause problems and may leak some code.

Ref: https://github.com/MicrosoftDocs/PowerShell-Docs/wiki/The-case-for-and-against-Invoke-Expression

Motivation and Context

• Closes Bot set wrong version to many packages. Extras#8494
• Closes Something terribly wrong just happened Extras#8498
• Closes Action/PR: Avoid $version in checkver script GithubActions#8

How Has This Been Tested?

• scoop -v
• scoop update
• scoop install gnupg
• .\bin\checkver i* in 'extras' bucket
• .\test.ps1

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

[rashil2000]

There are multiple instances of such commands:

$currentBranch = Invoke-Command { git -C "$currentdir" branch }

Why not just replace them with:

$currentBranch = git -C "$currentdir" branch

[niheaven]

Invoke-Command run the script block in a child scope, so it should be safer and could improve readability.

[rashil2000]

Scope doesn't matter for git (and other similar external commands) right? On the other hand, I feel it hampers readability because it makes it seem like git commands need special handling.

For strings containing PowerShell code, it makes sense.

[niheaven]

Great, let's try and see if there are unexpected bugs.

[niheaven]

Removed Invoke-Command before git, and tested okay here.