Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scoop-update): Support scoop update scoop #4992

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented Jun 17, 2022

Description

Support scoop update scoop

Motivation and Context

Closes #4940
Relates to #4811

How Has This Been Tested?

scoop update
scoop update *
scoop update --all
scoop update scoop
scoop update scoop git

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@lewis-yeung
Copy link
Contributor

The #4940 can be closed as well once this goes live.

@chawyehsu chawyehsu marked this pull request as ready for review June 17, 2022 10:46
@niheaven niheaven merged commit 666d474 into develop Jun 20, 2022
@niheaven niheaven deleted the chawyehsu-patch-1 branch June 20, 2022 06:43
@rashil2000
Copy link
Member

rashil2000 commented Jun 21, 2022

There is a side effect due to this change:

$apps = $apps | Where-Object { $_ -ne 'scoop' }

Earlier, when running scoop update -a, only those apps that were outdated were shown (see first command below). After this change, all apps are shown (second command below).

Screenshot 2022-06-22 002044

@rashil2000
Copy link
Member

@chawyehsu any update on this?

@chawyehsu
Copy link
Member Author

chawyehsu commented Jul 1, 2022

@rashil2000 Sorry for late response, I haven't been able to use the internet in the past few days.

No update on that yet. But I suppose there needs to be a condition checking of $all here similar to this one.

@rashil2000
Copy link
Member

Okay, I have added the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants