Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scoop-status): Check bucket status, improve output #5011

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

rashil2000
Copy link
Member

@rashil2000 rashil2000 commented Jun 21, 2022

Description

  • Return PSObject (as usual 😂)
  • Check for network failures
  • Check update status of buckets

Motivation and Context

Closes #3549
Closes #4615
Closes #3188

Relates to #3550

How Has This Been Tested?

Screenshot 2022-06-21 225130

Screenshot 2022-06-21 235038

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven
Copy link
Member

Some naming suggestions: 'Current Version' -> 'Installed Version', 'Info' -> 'Additional Info'.

@rashil2000
Copy link
Member Author

I've changed 'Current Version' to 'Installed Version' but kept 'Info' for consistency with scoop-list

Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashil2000 rashil2000 merged commit 6629331 into develop Jun 22, 2022
@rashil2000 rashil2000 deleted the refactor-status branch June 22, 2022 10:10
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
…er#5011)

* feat(scoop-status): Check bucket status, improve output

* Update CHANGELOG.md
@dem2k
Copy link

dem2k commented Jul 8, 2022

image

@rashil2000
Copy link
Member Author

Can you run it with OhMyPosh disabled?

@dem2k
Copy link

dem2k commented Jul 8, 2022

same result :(

image

image

@rashil2000
Copy link
Member Author

Please create a new issue so that we can investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants