Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scoop-import): Import a Scoop installation from JSON #5014

Merged
merged 7 commits into from
Jun 24, 2022
Merged

feat(scoop-import): Import a Scoop installation from JSON #5014

merged 7 commits into from
Jun 24, 2022

Conversation

rashil2000
Copy link
Member

@rashil2000 rashil2000 commented Jun 22, 2022 •
edited
Loading

Description

Awesome new feature of Scoop! 🎉🎊

Export to and import a Scoop installation from a JSON file.

Motivation and Context

Closes #3934

How Has This Been Tested?

scoop export -c > Desktop\scoopfile.json
scoop import Desktop\scoopfile.json

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

niheaven
niheaven reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the import feature, but it's okay in static reviews.

libexec/scoop-import.ps1 Outdated Show resolved Hide resolved
@rashil2000
Copy link
Member Author

@niheaven anything remaining here?

@rashil2000 rashil2000 merged commit c4d1b9c into develop Jun 24, 2022
@rashil2000 rashil2000 deleted the feat-import branch June 24, 2022 05:42
@zStruCat
Copy link
Contributor

zStruCat commented Jul 1, 2022 •
edited
Loading

One minor issue:
Regarding
scoop export -c > Desktop\scoopfile.json
"-c" option seems not covered in scoop help export.
I presume it means create? But the command does create a file without "-c".

@rashil2000 rashil2000 mentioned this pull request Jul 1, 2022
Merged
5 tasks
@rashil2000
Copy link
Member Author

Thanks for noticing @zStruCat! It was a typo and I've fixed it

@niheaven niheaven mentioned this pull request Jul 2, 2022
Merged
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
@rashil2000 @slaughtering
feat(scoop-import): Import a Scoop installation from JSON (ScoopInsta…
d04581f 
…ller#5014)

* feat(scoop-export): Export Scoop installation in JSON

* optimize

* yesss done

* complete

* Update CHANGELOG.md

* Add suggestions from code review

* fix CI
@basejumpa basejumpa mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rashil2000 @zStruCat @niheaven