Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkver,auto-pr): Allow passing file path #5019

Merged
merged 4 commits into from
Jul 1, 2022
Merged

feat(checkver,auto-pr): Allow passing file path #5019

merged 4 commits into from
Jul 1, 2022

Conversation

rashil2000
Copy link
Member

@rashil2000 rashil2000 commented Jun 24, 2022 •
edited
Loading

Description

Allow passing local file paths to checkver utility.

Motivation and Context

Closes #4606

Relates to #3481

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@rashil2000 rashil2000 mentioned this pull request Jun 24, 2022
Closed
@niheaven
Copy link
Member

Please use ParameterSet to choose between Dir and File, or rename them to Path and check if it is directory or file later. The latter approach is better, IMO.

@rashil2000
Copy link
Member Author

rashil2000 commented Jun 27, 2022 •
edited
Loading

I have reused the $App parameter (like the linked PR)

niheaven
niheaven reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remark, this should go to Builds in CHANGELOG

@rashil2000 rashil2000 merged commit 53f0e9a into develop Jul 1, 2022
@rashil2000 rashil2000 deleted the checkver-file branch July 1, 2022 06:42
@niheaven niheaven mentioned this pull request Jul 2, 2022
Merged
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
@rashil2000 @slaughtering
feat(checkver,auto-pr): Allow passing file path (ScoopInstaller#5019)
f9d765b 
* feat(checkver,auto-pr): Allow passing file path

* changelog

* reuse $App parameter

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rashil2000 @niheaven