Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkurls): Allow checking URLs from private_hosts #5152

Merged
merged 4 commits into from
Sep 16, 2022
Merged

feat(checkurls): Allow checking URLs from private_hosts #5152

merged 4 commits into from
Sep 16, 2022

Conversation

cesarcoatl
Copy link
Contributor

@cesarcoatl cesarcoatl commented Sep 15, 2022 •
edited
Loading

Description

Similar to #4254 but for .\bin\checkurls.ps1.

Motivation and Context

Closes #5150

How Has This Been Tested?

I have made the changes locally and ran the command successfully.

Before:

$ .\bin\checkurls.ps1
[U]RLs
 | [O]kay
 |  | [F]ailed
 |  |  |
[1][0][1] ignition
       > The remote server returned an error: (403) Forbidden. (https://files.inductiveautomation.com/release/ia/8.1.20/20220823-1339/Ignition-windows-x86-64-8.1.20.zip)
[1][1][0] jython

After:

$ .\bin\checkurls.ps1
[U]RLs
 | [O]kay
 |  | [F]ailed
 |  |  |
[1][1][0] ignition
[1][1][0] jython

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@cesarcoatl cesarcoatl mentioned this pull request Sep 15, 2022
Closed
@cesarcoatl
Copy link
Contributor Author

Supersedes #5151

👀 @rashil2000

@niheaven niheaven merged commit 782f3f1 into ScoopInstaller:develop Sep 16, 2022
@niheaven niheaven linked an issue Sep 16, 2022 that may be closed by this pull request
Allow checkurls.ps1 to check URLs from private_hosts #5150
Closed
@cesarcoatl cesarcoatl deleted the feat/checkurls/private_hosts branch September 16, 2022 22:09
@niheaven niheaven mentioned this pull request Sep 26, 2022
Merged
@KoltesDigital KoltesDigital mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow checkurls.ps1 to check URLs from private_hosts
2 participants
@cesarcoatl @niheaven