Merge pull request #391 from ScorexFoundation/update-deps

Update scorex-util and scrypto deps, fix tests
hyperledger-labs · Nov 19, 2020 · b8f1c5f · b8f1c5f
2 parents 96036a0 + d620327
commit b8f1c5f
Show file tree

Hide file tree

Showing 41 changed files with 187 additions and 170 deletions.
diff --git a/build.sbt b/build.sbt
@@ -98,20 +98,21 @@ val loggingDependencies = Seq(
   "ch.qos.logback" % "logback-classic" % "1.3.0-alpha4"
 )
 
-val scorexUtil = "org.scorexfoundation" %% "scorex-util" % "0.1.6"
+val scorexUtil = "org.scorexfoundation" %% "scorex-util" % "0.1.8"
 
 val testingDependencies = Seq(
   "com.typesafe.akka" %% "akka-testkit" % akkaVersion % "test",
   "com.typesafe.akka" %% "akka-http-testkit" % akkaHttpVersion % "test",
   "org.scalactic" %% "scalactic" % "3.0.3" % "test",
-  "org.scalatest" %% "scalatest" % "3.0.3" % "test",
-  "org.scalacheck" %% "scalacheck" % "1.13.+",
+  "org.scalatest" %% "scalatest" % "3.1.1" % "test",
+  "org.scalacheck" %% "scalacheck" % "1.14.+",
+  "org.scalatestplus" %% "scalatestplus-scalacheck" % "3.1.0.0-RC2" % Test,
   scorexUtil, (scorexUtil % Test).classifier("tests")
 )
 
 libraryDependencies ++= Seq(
   "com.iheart" %% "ficus" % "1.4.2",
-  "org.scorexfoundation" %% "scrypto" % "2.1.7",
+  "org.scorexfoundation" %% "scrypto" % "2.1.10",
   scorexUtil
 ) ++ networkDependencies ++ apiDependencies ++ loggingDependencies ++ testingDependencies
 

diff --git a/examples/build.sbt b/examples/build.sbt
@@ -2,8 +2,9 @@ name := "scorex-examples"
 
 libraryDependencies ++= Seq(
   "org.scalactic" %% "scalactic" % "3.0.1" % "test",
-  "org.scalatest" %% "scalatest" % "3.0.1" % "test",
-  "org.scalacheck" %% "scalacheck" % "1.13.+" % "test",
+  "org.scalatest" %% "scalatest" % "3.1.1" % "test",
+  "org.scalacheck" %% "scalacheck" % "1.14.+" % "test",
+  "org.scalatestplus" %% "scalatestplus-scalacheck" % "3.1.0.0-RC2" % Test,
   "org.scorexfoundation" %% "iodb" % "0.3.2",
   "com.typesafe.akka" %% "akka-testkit" % "2.6.10" % "test"
 )

diff --git a/examples/src/test/scala/hybrid/history/HybridHistorySpecification.scala b/examples/src/test/scala/hybrid/history/HybridHistorySpecification.scala
@@ -3,17 +3,17 @@ package hybrid.history
 import examples.hybrid.history.{HybridHistory, HybridSyncInfo}
 import hybrid.HybridGenerators
 import org.scalacheck.Gen
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
-import scorex.core.consensus.History.{Equal, HistoryComparisonResult, Older, Younger}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
+import scorex.core.consensus.History.{Older, HistoryComparisonResult, Equal, Younger}
 import scorex.core.utils.ScorexEncoding
 import scorex.core.ModifierTypeId
 import scorex.util.ModifierId
 
 @SuppressWarnings(Array("org.wartremover.warts.TraversableOps", "org.wartremover.warts.OptionPartial"))
-class HybridHistorySpecification extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class HybridHistorySpecification extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators
   with ScorexEncoding {

diff --git a/examples/src/test/scala/hybrid/history/IODBSpecification.scala b/examples/src/test/scala/hybrid/history/IODBSpecification.scala
@@ -5,15 +5,16 @@ import examples.hybrid.blocks.{HybridBlock, PosBlock, PowBlock}
 import hybrid.HybridGenerators
 import io.iohk.iodb.{ByteArrayWrapper, LSMStore}
 import org.scalacheck.Gen
-import org.scalatest.prop.GeneratorDrivenPropertyChecks
-import org.scalatest.{Matchers, Outcome, fixture}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.{fixture, Outcome}
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.utils.ScorexEncoding
 import scorex.testkit.utils.FileUtils
 import scorex.util.ModifierId
 
 @SuppressWarnings(Array("org.wartremover.warts.TraversableOps"))
 class IODBSpecification extends fixture.PropSpec
-  with GeneratorDrivenPropertyChecks
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators
   with FileUtils

diff --git a/examples/src/test/scala/hybrid/primitives/PrivateKey25519Suite.scala b/examples/src/test/scala/hybrid/primitives/PrivateKey25519Suite.scala
@@ -2,14 +2,14 @@ package hybrid.primitives
 
 import examples.commons.PublicKey25519NoncedBox
 import hybrid.HybridGenerators
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.transaction.state.PrivateKey25519Companion
 
 @SuppressWarnings(Array("org.wartremover.warts.OptionPartial"))
-class PrivateKey25519Suite extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class PrivateKey25519Suite extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators {
 

diff --git a/examples/src/test/scala/hybrid/serialization/SerializationTests.scala b/examples/src/test/scala/hybrid/serialization/SerializationTests.scala
@@ -4,15 +4,15 @@ import examples.commons.{PublicKey25519NoncedBox, PublicKey25519NoncedBoxSeriali
 import examples.hybrid.blocks.{PosBlock, PosBlockSerializer, PowBlock, PowBlockSerializer}
 import examples.hybrid.history.{HybridSyncInfo, HybridSyncInfoSerializer}
 import hybrid.HybridGenerators
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
 import scorex.core.transaction.wallet.{WalletBox, WalletBoxSerializer}
 
 @SuppressWarnings(Array("org.wartremover.warts.TraversableOps"))
-class SerializationTests extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class SerializationTests extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators {
 

diff --git a/examples/src/test/scala/hybrid/state/HBoxStoredStateSpecification.scala b/examples/src/test/scala/hybrid/state/HBoxStoredStateSpecification.scala
@@ -3,15 +3,15 @@ package hybrid.state
 import examples.hybrid.blocks.HybridBlock
 import examples.hybrid.state.HBoxStoredState
 import hybrid.HybridGenerators
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.transaction.state.{Insertion, Removal}
 import scorex.testkit.properties.state.StateTests
 
 @SuppressWarnings(Array("org.wartremover.warts.OptionPartial"))
-class HBoxStoredStateSpecification extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class HBoxStoredStateSpecification extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators
   with StateTests[HybridBlock, HBoxStoredState] {

diff --git a/examples/src/test/scala/hybrid/state/SimpleBoxTransactionSpecification.scala b/examples/src/test/scala/hybrid/state/SimpleBoxTransactionSpecification.scala
@@ -3,8 +3,9 @@ package hybrid.state
 import examples.commons.{Nonce, PublicKey25519NoncedBox, SimpleBoxTransaction, Value}
 import examples.hybrid.state.HBoxStoredState
 import hybrid.HybridGenerators
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
 import scorex.core.transaction.proof.{Signature25519, Signature25519Serializer}
 import scorex.core.transaction.state.PrivateKey25519Companion
@@ -13,9 +14,8 @@ import scorex.crypto.hash.Sha256
 import scorex.crypto.signatures.{PublicKey, Signature}
 
 @SuppressWarnings(Array("org.wartremover.warts.TraversableOps"))
-class SimpleBoxTransactionSpecification extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class SimpleBoxTransactionSpecification extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators {
 

diff --git a/examples/src/test/scala/hybrid/transaction/TransactionSuite.scala b/examples/src/test/scala/hybrid/transaction/TransactionSuite.scala
@@ -3,14 +3,14 @@ package hybrid.transaction
 import examples.commons.SimpleBoxTransaction
 import hybrid.HybridGenerators
 import io.iohk.iodb.ByteArrayWrapper
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.transaction.state.PrivateKey25519Companion
 
 
-class TransactionSuite extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class TransactionSuite extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators {
 

diff --git a/examples/src/test/scala/hybrid/validation/SemanticBlockValidatorSpecification.scala b/examples/src/test/scala/hybrid/validation/SemanticBlockValidatorSpecification.scala
@@ -2,14 +2,14 @@ package hybrid.validation
 
 import examples.hybrid.validation.SemanticBlockValidator
 import hybrid.HybridGenerators
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.crypto.hash.Blake2b256
 
 
-class SemanticBlockValidatorSpecification extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class SemanticBlockValidatorSpecification extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators {
 

diff --git a/examples/src/test/scala/hybrid/wallet/HWalletSpecification.scala b/examples/src/test/scala/hybrid/wallet/HWalletSpecification.scala
@@ -4,8 +4,9 @@ import examples.commons.Value
 import examples.hybrid.blocks.PosBlock
 import examples.hybrid.wallet.HBoxWallet
 import hybrid.HybridGenerators
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.bytesToId
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
 import scorex.core.transaction.proof.Signature25519
@@ -16,9 +17,8 @@ import scala.annotation.tailrec
 import scala.util.Random
 
 @SuppressWarnings(Array("org.wartremover.warts.TraversableOps"))
-class HWalletSpecification extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class HWalletSpecification extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with HybridGenerators {
 

diff --git a/examples/src/test/scala/spv/ChainTests.scala b/examples/src/test/scala/spv/ChainTests.scala
@@ -3,18 +3,18 @@ package spv
 import examples.spv.simulation.SimulatorFuctions
 import examples.spv.{Header, KLS16ProofSerializer, KMZProofSerializer, SpvAlgos}
 import org.scalacheck.Gen
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
 import scorex.core.transaction.state.{PrivateKey25519, PrivateKey25519Companion}
 import scorex.crypto.hash
 import scorex.crypto.hash.Blake2b256
 import scorex.util.ModifierId
 
 @SuppressWarnings(Array("org.wartremover.warts.TraversableOps"))
-class ChainTests extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class ChainTests extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with SPVGenerators
   with SimulatorFuctions {

diff --git a/examples/src/test/scala/spv/serialization/SerializationTests.scala b/examples/src/test/scala/spv/serialization/SerializationTests.scala
@@ -1,13 +1,13 @@
 package spv.serialization
 
 import examples.spv.{Header, HeaderSerializer}
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import spv.SPVGenerators
 
-class SerializationTests extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class SerializationTests extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with SPVGenerators {
 

diff --git a/examples/src/test/scala/trimchain/serialization/SerializationTests.scala b/examples/src/test/scala/trimchain/serialization/SerializationTests.scala
@@ -2,13 +2,13 @@ package trimchain.serialization
 
 import examples.trimchain.core.{Ticket, TicketSerializer}
 import examples.trimchain.modifiers.{BlockHeader, BlockHeaderSerializer, TBlock, TBlockSerializer}
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import org.scalatest.{Matchers, PropSpec}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
 import trimchain.TrimchainGenerators
 
-class SerializationTests extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class SerializationTests extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers
   with TrimchainGenerators {
 

diff --git a/src/main/scala/scorex/util/serialization/VLQByteStringReader.scala b/src/main/scala/scorex/util/serialization/VLQByteStringReader.scala
@@ -34,6 +34,7 @@ class VLQByteStringReader(byteString: ByteString) extends VLQReader {
 
   @inline
   override def getBytes(size: Int): Array[Byte] = {
+    require(size <= remaining, s"Not enough bytes in the buffer: $size")
     incPosition(size)
     it.getBytes(size)
   }

diff --git a/src/main/scala/scorex/util/serialization/VLQByteStringWriter.scala b/src/main/scala/scorex/util/serialization/VLQByteStringWriter.scala
@@ -37,6 +37,13 @@ class VLQByteStringWriter extends VLQWriter {
     this
   }
 
+  override def putBytes(xs: Array[Byte],
+                        offset: Int,
+                        length: Int): VLQByteStringWriter.this.type = {
+    builder.putBytes(xs, offset, length)
+    this
+  }
+
   @inline
   override def putBytes(xs: Array[Byte]): this.type = {
     builder.putBytes(xs)

diff --git a/src/test/scala/scorex/core/DefaultModifiersCacheSpecification.scala b/src/test/scala/scorex/core/DefaultModifiersCacheSpecification.scala
@@ -1,17 +1,17 @@
 package scorex.core
 
-import org.scalatest.{Matchers, PropSpec}
-import org.scalatest.prop.{GeneratorDrivenPropertyChecks, PropertyChecks}
-import scorex.core.consensus.{History, HistoryReader, ModifierSemanticValidity, SyncInfo}
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.propspec.AnyPropSpec
+import org.scalatestplus.scalacheck.ScalaCheckPropertyChecks
+import scorex.core.consensus.{SyncInfo, History, HistoryReader, ModifierSemanticValidity}
 import scorex.core.consensus.History.ModifierIds
 import scorex.core.serialization.ScorexSerializer
 import scorex.crypto.hash.Blake2b256
 
 import scala.util.Try
 
-class DefaultModifiersCacheSpecification extends PropSpec
-  with PropertyChecks
-  with GeneratorDrivenPropertyChecks
+class DefaultModifiersCacheSpecification extends AnyPropSpec
+  with ScalaCheckPropertyChecks
   with Matchers {
 
   private class FakeModifier extends PersistentNodeViewModifier {

diff --git a/src/test/scala/scorex/core/api/http/ApiResponseTest.scala b/src/test/scala/scorex/core/api/http/ApiResponseTest.scala
@@ -4,11 +4,12 @@ import akka.http.scaladsl.model.{HttpRequest, StatusCodes}
 import akka.http.scaladsl.testkit.ScalatestRouteTest
 import io.circe.Json
 import io.circe.syntax._
-import org.scalatest.{FlatSpec, Matchers}
+import org.scalatest.flatspec.AnyFlatSpec
+import org.scalatest.matchers.should.Matchers
 
 import scala.concurrent.Future
 
-class ApiResponseTest extends FlatSpec with Matchers with ScalatestRouteTest {
+class ApiResponseTest extends AnyFlatSpec with Matchers with ScalatestRouteTest {
 
   private val request = HttpRequest()
 

diff --git a/src/test/scala/scorex/core/api/http/PeersApiRouteSpec.scala b/src/test/scala/scorex/core/api/http/PeersApiRouteSpec.scala
@@ -2,20 +2,21 @@ package scorex.core.api.http
 
 import java.net.InetSocketAddress
 
-import akka.http.scaladsl.model.{ContentTypes, HttpEntity, StatusCodes}
-import akka.http.scaladsl.testkit.{RouteTestTimeout, ScalatestRouteTest}
+import akka.http.scaladsl.model.{ContentTypes, StatusCodes, HttpEntity}
+import akka.http.scaladsl.testkit.{ScalatestRouteTest, RouteTestTimeout}
 import akka.testkit.TestDuration
 import io.circe.Json
 import io.circe.syntax._
-import org.scalatest.{FlatSpec, Matchers}
+import org.scalatest.flatspec.AnyFlatSpec
+import org.scalatest.matchers.should.Matchers
 import scorex.core.api.http.PeersApiRoute.PeerInfoResponse
 import scorex.core.settings.{RESTApiSettings, ScorexSettings}
 import scorex.core.utils.NetworkTimeProvider
 
 import scala.concurrent.duration._
 import scala.language.postfixOps
 
-class PeersApiRouteSpec extends FlatSpec
+class PeersApiRouteSpec extends AnyFlatSpec
   with Matchers
   with ScalatestRouteTest
   with Stubs {