-
Notifications
You must be signed in to change notification settings - Fork 115
Integrate NVHTests and NVSTests in BlockchainSanity #110
Conversation
…ompiling. [error] /Users/Bruno/Dropbox/Code/Scorex/testkit/src/main/scala/scorex/testkit/BlockchainSanity.scala:39:10: illegal inheritance; superclass PropSpec [error] is not a subclass of the superclass PropSpec [error] of the mixin trait NodeViewHolderTests [error] with NodeViewHolderTests[P, TX, PM, ST, SI, HT, MPool] [error] ^ [error] /Users/Bruno/Dropbox/Code/Scorex/testkit/src/main/scala/scorex/testkit/BlockchainSanity.scala:40:10: illegal inheritance; superclass PropSpec [error] is not a subclass of the superclass PropSpec [error] of the mixin trait NodeViewSynchronizerTests [error] with NodeViewSynchronizerTests[P, TX, PM, ST, SI, HT] { [error] ^ [error] two errors found [error] (testkit/compile:compileIncremental) Compilation failed
Integrate NVHTests and NVSTests in BlockchainSanity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style fixes required
val fixture = new HolderFixture | ||
try { | ||
testCode(fixture) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use one line codestyle, like
} finally {
See #118 . I don't have push access to this repo. That's why I couldn't push the fix directly into this pull request. |
This is the test that failed:
|
Changes Unknown when pulling 19d9f9e on more-props into ** on master**. |
Ok. I re-executed the failing build in Travis, and it succeeded this time... |
I removed the obsolete failing test. There is another test that sometimes fails, but this is not caused by this MR. The problem is discussed here (#119). |
No description provided.