Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Remove Node Nonce #127

Merged
merged 6 commits into from
Dec 22, 2017
Merged

Conversation

ceilican
Copy link
Contributor

@ceilican ceilican commented Dec 9, 2017

  • remove nonce from settings
  • make bindAddress and declaredAddress parse as InetSocketAddress instead of String.
  • investigate why one test is failing:
[info] - NodeViewHolder: simple forking *** FAILED ***
[info]   java.lang.AssertionError: assertion failed: timeout (3 seconds) during expectMsgClass waiting for class scorex.core.NodeViewHolder$SyntacticallySuccessfulModifier
[info]   at scala.Predef$.assert(Predef.scala:219)
[info]   at akka.testkit.TestKitBase.expectMsgClass_internal(TestKit.scala:472)
[info]   at akka.testkit.TestKitBase.expectMsgType(TestKit.scala:445)
[info]   at akka.testkit.TestKitBase.expectMsgType$(TestKit.scala:445)
[info]   at akka.testkit.TestKit.expectMsgType(TestKit.scala:814)
[info]   at scorex.testkit.properties.NodeViewHolderTests.$anonfun$$init$$32(NodeViewHolderTests.scala:199)
[info]   at scorex.testkit.properties.NodeViewHolderTests.$anonfun$$init$$32$adapted(NodeViewHolderTests.scala:173)
[info]   at scorex.testkit.properties.NodeViewHolderTests.withFixture(NodeViewHolderTests.scala:47)
[info]   at scorex.testkit.properties.NodeViewHolderTests.$anonfun$$init$$31(NodeViewHolderTests.scala:173)
[info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)

@ceilican
Copy link
Contributor Author

ceilican commented Dec 9, 2017

One test is failing. I will investigate why.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1fffa9e on ceilican:remove-node-nonce into ** on ScorexFoundation:master**.

@ceilican
Copy link
Contributor Author

ceilican commented Dec 9, 2017

It turns out that the test succeeded when I re-ran the build in Travis. So, this is another test that is failing intermittently. I will add it to issue #119.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 45.587% when pulling 2723a7a on ceilican:remove-node-nonce into e39d606 on ScorexFoundation:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 45.587% when pulling 4bf6512 on ceilican:remove-node-nonce into 77593e2 on ScorexFoundation:master.

@ceilican ceilican changed the title WIP: Remove Node Nonce Remove Node Nonce Dec 15, 2017
@ceilican ceilican requested a review from kushti December 15, 2017 04:08
@ceilican
Copy link
Contributor Author

@kushti , because of the removal of nodeNonce, I had to change a few things in the handshake. I left a few "TODOs" in places that should be checked carefully by you, because my changes may have broken the intended handshake logic.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 45.587% when pulling 8a9c454 on ceilican:remove-node-nonce into 77593e2 on ScorexFoundation:master.

@ceilican ceilican mentioned this pull request Dec 15, 2017
# Conflicts:
#	src/main/resources/reference.conf
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 95fe994 on ceilican:remove-node-nonce into ** on ScorexFoundation:master**.

@kushti kushti merged commit 95fe994 into hyperledger-labs:master Dec 22, 2017
@ceilican ceilican deleted the remove-node-nonce branch January 13, 2018 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants