This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Fixing "too many open files" error in tests #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
approved these changes
Jul 27, 2020
aslesarenko
reviewed
Jul 27, 2020
| @@ -35,21 +33,22 @@ trait FileUtils { | |||
| createTempDirForPrefix(prefix) | |||
| } | |||
|
|
|||
|
|
|||
| @SuppressWarnings(Array("org.wartremover.warts.Recursion")) | |||
There was a problem hiding this comment.
Please add ScalaDoc, in particular describing the rationale behind not deleting some of the files.
There was a problem hiding this comment.
Removed preserving hidden files (it was copy-pasted from the internets likely), also, made the deleteRecursive method internal to remove()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently "too many open files" error appears in tests. The error is rooting in how recursive deletion is implemented in scorex.testkit.utils.FileUtils.remove(). This PR fixes the problematic recursive files deletion.
The fix is made by @knizhnik and extracted from the #362 .