This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently messages received from a remote peer are parsed by the NetworkController before being sent to the respective handlers. However, the message parsing does not need to happen at the NetworkController stage and can instead be passed to appropriate handler (aka a Synchronzier). In the current setup there are two issues that may be addressed:
Proposed solution
A Synchronizer trait has been created and implemented by NodeViewSynchronizer and PeerSychronizer. This trait defines a common definition for parsing a message received from a remote peer and handing the parsed data off to a specified function for processing. This also allows for us to get rid of the DataFromPeer class a use a single representation of message data for both ingress and egress traffic.