Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DEFENCE_TYPES enum #184

Closed
gsproston-scottlogic opened this issue Aug 23, 2023 · 0 comments · Fixed by #186
Closed

Use DEFENCE_TYPES enum #184

gsproston-scottlogic opened this issue Aug 23, 2023 · 0 comments · Fixed by #186
Assignees
Labels
backend Requires work on the backend frontend Requires work on the frontend refactor Improve code quality
Milestone

Comments

@gsproston-scottlogic
Copy link
Contributor

There's a lot of instances in the code where strings are used to identify defences. Instead, use the DEFENCE_TYPES enum.

@gsproston-scottlogic gsproston-scottlogic added frontend Requires work on the frontend backend Requires work on the backend refactor Improve code quality labels Aug 23, 2023
@gsproston-scottlogic gsproston-scottlogic added this to the Sandbox milestone Aug 23, 2023
@gsproston-scottlogic gsproston-scottlogic self-assigned this Aug 23, 2023
@gsproston-scottlogic gsproston-scottlogic linked a pull request Aug 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires work on the backend frontend Requires work on the frontend refactor Improve code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant