SignalXY support for parallel processing and render index limits #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code has been substantially reworked
swharden
changed the title
swharden
added a commit
that referenced
this pull request
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Parallel processing for
PlottableSignalXY#419For now
PlottableSignalXYsupportuseParallelflag to enable/disable parallel processing.Existing code has been substantially reworked, to make it unrelated between iterations and without parallel/sequental code duplicates. Similar to the
PlottableSignal#454 approachBinary search is now used to find indexes in
xsarray. This should also improve performance.PlottableSignalXYnow respects tominRenderIndexandmaxRenderIndex#493. PR #495 deprecated now.Additionaly fix
PlottableSignallimits calculations.New functionality (code):
New functionality (image):