-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed 'min cycles' after call reload service #128
Comments
Hello, please test with master branch. |
OK, I'll try it, I just upgraded it following the HACS notification, and I'm running 2023.1.1 |
6 Hours ago (more or less) I download the master version, restart HA, and call the reload service. So, @ScratMan, you are right, in this versions seems to works! Do you plan to release a version with a mayor number to avoid the HACS repository alert you with a new update? Thanks! |
Yes, i'll push a release. |
Hi again @ScratMan, I guess something similar is happening with the constants kp, ki, kd & ke... They are not updated if the yaml is modified... |
That's normal. The PID gains and preset temperatures are always restored from previous state stored in HA database. Once HA is running, gains and preset should be modified using the corresponding services, they are applied without need of reboot. I recommend to update the YAML once you've found the best settings that fit your needs. |
ACK, I added it by the service once I noticed they weren't updated from the yaml. Thanks for clarify it. |
@ScratMan, I'm using version 2023.10.0 and also noticed that
|
Describe the bug
After call to the reload service, the min periods (at least
min_cycle_duration
andmin_off_cycle_duration
) are not taken in account anymore.To Reproduce
Steps to reproduce the behavior:
min_cycle_duration
in the yaml config file.min_cycle_duration
Expected behavior
Respect the time of the "min..." periods.
Screenshots
Same configuration, but during the morning min times are not applied (I performed a reload last night), during the evening after a HA restart.
The text was updated successfully, but these errors were encountered: