New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection region is off on integer scaling #18
Comments
Thanks for submitting the issue! Kooha uses a method in the dbus interface of gnome shell. |
GNOME screenshot works fine; it records exactly the region I selected. |
I'll investigate on it. |
Just FYI, when I set GNOME's screen scale to 100% it records the correct region. |
Not replicable on my end. I set up my display to be 175%, and it still records the correct area. It might be that you set it to 200%? I can't seem to find that option. |
GNOME by default only allows scaling to integers, eg 100%, 200%, 300%, you might have experimental fractional scaling enabled or an experimental/hacked version installed. I could try replicatign with a stock Fedora install with 200% scaling later. |
I cannot find the options for integer scaling, is it only available from hidpi's? |
Hi, I'm thinking of removing selection support, so I would like to know your opinions whether its the right choice. The reason is that it will be useless for most, since it would be possible now to select a specific monitor, or window to record. |
For me, personally, it's an essential feature. This would force me to find another tool. |
For me, it's an essential feature, too. I use this feature to crop off sensitive sections of my screen that I don't want to share in the recorded video. |
I'm working on it, besides maintaining the feature, I'll support other desktop environments and fix this scaling issue. Check #73 |
I found the issue, it was that the original resolution should be divided by the actual resolutions of your screen then multiply back to x, y width and height Kooha/src/backend/pipeline_builder.py Line 66 in 39dc1e6
840 being the actual resolution, but haven't find a way for now how to get this value in GTK4 |
pushed the fix in development branch :D Feel free to test it |
fix merged to main branch |
@SeaDve Is there any rough estimate of when the new release will be available? Thanks for the fix!!!! |
Possibly after the release of GTK 4.3.3 Check #75 for the todo |
Sorry for the late response (have been very busy). I verified that the fix works. Many thanks!! 😃 👍 |
Arch Linux, using Kooha 1.0.2, installed from AUR https://aur.archlinux.org/packages/kooha
I have a Hi-DPI screen with 3840x2160 pixels, 290 dpi. GNOME display scaled to 200%.
When I record a screen region, it seems that the real coordinates of the rectangle that defines the region are off by one half. Ie. when I define to record the region from (200,200) to (500,500), Kooha really records the region from (100,100) to (250,250).
The text was updated successfully, but these errors were encountered: