Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #3

Closed
SeanMcP opened this issue Nov 21, 2022 · 1 comment
Closed

Add types #3

SeanMcP opened this issue Nov 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@SeanMcP
Copy link
Owner

SeanMcP commented Nov 21, 2022

Add exported type interfaces for the Astro components.

import {HTMLAttributes} from 'astro/types';

type Props = HTMLAttributes<'svg'>;

Does it have to be an interface? https://docs.astro.build/en/core-concepts/astro-components/#component-props
@SeanMcP SeanMcP added the enhancement New feature or request label Nov 21, 2022
@SeanMcP SeanMcP mentioned this issue Nov 21, 2022
Merged
@SeanMcP
Copy link
Owner Author

SeanMcP commented Nov 22, 2022

Fixed in #4

@SeanMcP SeanMcP closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SeanMcP