Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPPharoPlatform>>#handleRequest: contains commented-out code to strip NULL characters from the response #22

Open
Rinzwind opened this issue Oct 31, 2018 · 0 comments

Comments

@Rinzwind
Copy link
Member

There's some code in the method BPPharoPlatform>>#handleRequest: to strip trailing NULL characters from the response:

"Carsten Haerle: Why is that necessary? Is it possible to have trailing zeros? Not not be necessary."
"contents := contents copyFrom:1 to: (contents findLast: [:c | c asInteger ~= 0 ])."

Either that can be removed, or it should be re-enabled again. Based on the change done in 83ad7f2, I would say it might still be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant