Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove everything related to Pharo < 4 from baseline #1044

Closed
jecisc opened this issue Nov 20, 2018 · 13 comments
Closed

Remove everything related to Pharo < 4 from baseline #1044

jecisc opened this issue Nov 20, 2018 · 13 comments

Comments

@jecisc
Copy link
Member

jecisc commented Nov 20, 2018

Because now Seaside is only for Pharo 4+

@jecisc
Copy link
Member Author

jecisc commented Nov 20, 2018

We can also remove packages used only for Pharo < 5 and merge the packages like Javascript-Pharo20-Core with Javascript-Pharo-Core

@jecisc
Copy link
Member Author

jecisc commented Nov 20, 2018

Hum... Not so easy. I have the impression that packages named "pharo" are loaded by squeak...

Maybe we should rename *-Pharo-* into *-Squeak-* and *-Pharo20-* into *-Pharo-*?

@jbrichau
Copy link
Member

We are still testing for Pharo3 and 4 ... see travis line-up

@jecisc
Copy link
Member Author

jecisc commented Nov 24, 2018

I do not see Pharo 3 and 4 in the travis.ymd file

@jecisc
Copy link
Member Author

jecisc commented Nov 24, 2018

Oh, in the dev branch I see Pharo 4 but not 3.

@jecisc jecisc changed the title Remove everything related to Pharo < 5 from baseline Remove everything related to Pharo < 4 from baseline Nov 24, 2018
@jbrichau
Copy link
Member

Right. I meant 4 and 5.
We added 4 back because we could make the loading and testing work with metadataless filetree anyway.

I'm not sure renaming the Pharo20 package is a good idea when people would be upgrading their existing Seaside install in a Pharo 6 (or even 7). What happens when you first load master and then your branch?

@jecisc
Copy link
Member Author

jecisc commented Nov 24, 2018

It will probably move all the methods to the new package and leave an empty Pharo20 package I guess.

@jecisc
Copy link
Member Author

jecisc commented Nov 24, 2018

I find it a little confusing to have a package named "Pharo" that is only loaded in squeak and a package named "Pharo20" that is the default one for Pharo.

@jbrichau
Copy link
Member

I agree and it would be great to have that fixed. I'll run over the changes and integrate it.

@jecisc
Copy link
Member Author

jecisc commented Nov 24, 2018

My PR is only a first step. Since it impacts multiple smalltalk and a complex baseline I wanted to do it by steps.

@jecisc
Copy link
Member Author

jecisc commented Nov 24, 2018

If you prefer a PR with all the changes at once to review tell me and I'll do the other changes.

@jbrichau
Copy link
Member

Steps are good. Hold on a moment as I rename package extensions for Pharo7...

@marschall
Copy link
Contributor

The only thing referencing the old versions is the gettext baseline, this is addressed by #1131 .

And Javascript has a different baseline for Pharo 7.x so I'm closing this.

@marschall marschall added this to the 3.4 milestone Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants