Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

min_stock_amount should be float, not int #217

Closed
karwosts opened this issue Feb 20, 2022 · 1 comment · Fixed by #218
Closed

min_stock_amount should be float, not int #217

karwosts opened this issue Feb 20, 2022 · 1 comment · Fixed by #218
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@karwosts
Copy link

karwosts commented Feb 20, 2022 •
edited

Grocy allows min_stock_amount a value of up to 4 decimal places.

The ProductData class assumes this will be an int:

 min_stock_amount: Optional[int]

Can this be changed to a float? I have number of products with min stock of 1/4 of a bottle, etc, so I get validation errors processing my stock via HA custom integration.
@SebRut
Copy link
Owner

SebRut commented Feb 21, 2022

Of course! Would you feel comfortable to create a little PR to change this?

@SebRut SebRut added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Feb 21, 2022
@harshi1122 harshi1122 mentioned this issue Feb 21, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optional float harshi1122/pygrocy
2 participants
@SebRut @karwosts