Auto-convert string to Number for marker input #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 28.45% 28.37% -0.09%
==========================================
Files 30 30
Lines 1353 1357 +4
Branches 182 184 +2
==========================================
Hits 385 385
- Misses 966 970 +4
Partials 2 2
Continue to review full report at Codecov.
|
sebholstein
requested changes
Jun 12, 2018
packages/core/directives/marker.ts
Outdated
| @@ -158,8 +158,11 @@ export class AgmMarker implements OnDestroy, OnChanges, AfterContentInit { | |||
|
|
|||
| /** @internal */ | |||
| ngOnChanges(changes: {[key: string]: SimpleChange}) { | |||
| if (typeof this.latitude !== 'number' || typeof this.longitude !== 'number') { | |||
| return; | |||
| if (typeof this.latitude === 'string') { | |||
There was a problem hiding this comment.
this breaks the case that the marker only gets added to the manager if latitude/longitude are numbers. Can you add these check underneath?
There was a problem hiding this comment.
My bad! I added the check again
added 2 commits
June 13, 2018 09:38
|
Is this still relevant? If so I'd appreciate a new review |
sebholstein
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this PR, which seems to be put on hold by the original author.
I thought I'd give it a try so I incorporated your change request. Let me know if this is different from what you had in mind.
Fixes #771