Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rightclick event to marker #1443

Merged
merged 3 commits into from
Jul 4, 2018

Conversation

s-gbz
Copy link
Contributor

@s-gbz s-gbz commented Jun 29, 2018

Adds feature as requested in #1362.

Edit:
I should probably mention that npm run clang:format modifies 42 files. Is that unintentioned, or is the code not formatted properly?

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #1443 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
- Coverage   28.37%   28.36%   -0.01%     
==========================================
  Files          30       30              
  Lines        1357     1361       +4     
  Branches      184      185       +1     
==========================================
+ Hits          385      386       +1     
- Misses        970      973       +3     
  Partials        2        2
Impacted Files Coverage Δ
packages/core/directives/marker.ts 34.88% <25%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b7918...5526c8f. Read the comment docs.

@sebholstein
Copy link
Owner

@s-gbz thx! I'm working on moving to Prettier, so no worries :)

@sebholstein sebholstein merged commit 8abefa0 into sebholstein:master Jul 4, 2018
@s-gbz s-gbz deleted the right-click-event branch July 5, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants