Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rectangle support (rebase version) #1450

Merged
merged 1 commit into from
Jul 4, 2018
Merged

add rectangle support (rebase version) #1450

merged 1 commit into from
Jul 4, 2018

Conversation

sebholstein
Copy link
Owner

closes #1206

@sebholstein
Copy link
Owner Author

resolved conflicts, ported tests to Jest

add rectangle functionality

closes #570
@codecov
Copy link

codecov bot commented Jul 4, 2018

Codecov Report

Merging #1450 into master will increase coverage by 2.1%.
The diff coverage is 48.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1450     +/-   ##
=========================================
+ Coverage   26.34%   28.45%   +2.1%     
=========================================
  Files          28       30      +2     
  Lines        1226     1353    +127     
  Branches      159      182     +23     
=========================================
+ Hits          323      385     +62     
- Misses        901      966     +65     
  Partials        2        2
Impacted Files Coverage Δ
packages/core/services/google-maps-types.ts 0% <ø> (ø) ⬆️
packages/core/directives/map.ts 0% <0%> (ø) ⬆️
packages/core/core.module.ts 0% <0%> (ø) ⬆️
packages/core/services/google-maps-api-wrapper.ts 35.13% <25%> (-0.58%) ⬇️
packages/core/directives/rectangle.ts 44.82% <44.82%> (ø)
...ckages/core/services/managers/rectangle-manager.ts 64.7% <64.7%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c76e7e...289d5d4. Read the comment docs.

@sebholstein sebholstein merged commit 2e4878b into master Jul 4, 2018
@ghost ghost deleted the tim-rectangle branch September 17, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants