Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgmCircle dragStart event not working #1537

Closed
vguleaev opened this issue Nov 7, 2018 · 4 comments
Closed

AgmCircle dragStart event not working #1537

vguleaev opened this issue Nov 7, 2018 · 4 comments

Comments

@vguleaev
Copy link

vguleaev commented Nov 7, 2018

Issue description
AgmCircle dragStart event not working

Steps to reproduce and a minimal demo of the problem
Create an amg-circle and start draging.

Current behavior
Not fires. Only dragEnd fires

Expected/desired behavior
Should fire

angular2 & angular-google-maps version

Other information

@stale
Copy link

stale bot commented Feb 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 5, 2019
@stale stale bot closed this as completed Feb 12, 2019
@vguleaev
Copy link
Author

Nice, just close issues, dont solve them! ahahahah

@IsaacSomething
Copy link
Contributor

Hey... @vguleaev , there was a minor issue with the events.set('dragStart', this.dragStart); where the event set needs to be all lowercase. I made a pull requested for it #1618

. If you want to change this in your current project before a new release you can edit it in your /node_modules/@agm/core/directives/circle.js
and change the

events.set('dragStart', this.dragStart); line 140
to
events.set('dragstart', this.dragStart);

ghost pushed a commit that referenced this issue May 30, 2019
Minor change to casing on drag start event

Fixes #1537
@ghost
Copy link

ghost commented May 30, 2019

fixed

@ghost ghost removed the stale label May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants