Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitBounds breakes protractor tests #1548

Closed
magnattic opened this issue Nov 22, 2018 · 4 comments · Fixed by #1611
Closed

fitBounds breakes protractor tests #1548

magnattic opened this issue Nov 22, 2018 · 4 comments · Fixed by #1611

Comments

@magnattic
Copy link

Issue description
When using `[fitBounds]="true", protractor e2e tests time out.

Current behavior
My protractor tests time out if I add an agm-map with markers and [fitBounds]="true".
If I remove fitBounds, the tests run fine. This is likely due to some setTimeout being run within the ngZone.

Any chance this could be solved by using runOutsideAngular in the library?

@magnattic magnattic changed the title fitBounds brakes protractor tests fitBounds breakes protractor tests Nov 22, 2018
@stale
Copy link

stale bot commented Feb 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 20, 2019
@NikodemSuch
Copy link

Issue description
When using `[fitBounds]="true", protractor e2e tests time out.

Current behavior
My protractor tests time out if I add an agm-map with markers and [fitBounds]="true".
If I remove fitBounds, the tests run fine. This is likely due to some setTimeout being run within the ngZone.

Any chance this could be solved by using runOutsideAngular in the library?

I've encountered the same issue, @magnattic did you manage to solve it?

@stale stale bot removed the stale label Feb 26, 2019
@magnattic
Copy link
Author

Nope. we moved away from the library and implemented our own Maps solution. Unfortunately it looks like this project is not being developed much further. Such a shame, it really had promise. Hopefully someone finds the time to pick it up or branch it into something useful.

@stale
Copy link

stale bot commented May 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 28, 2019
@ghost ghost removed the stale label May 30, 2019
@ghost ghost closed this as completed in #1611 Jun 2, 2019
ghost pushed a commit that referenced this issue Jun 2, 2019
Fix fitBounds input in map.ts directive causing timeout in protractor
tests. _fitBoundsSubscription is now run outside angular ngZone to
prevent protractor from waiting for sample and timer rxjs operators
to sync map bounds.

closes #1548
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants