Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: _updateBounds not creating newBounds object #1553

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

subshock
Copy link
Contributor

A new LatLngBounds object is required to use the union method immediately afterwards

A new LatLngBounds object is required to use the union method immediately afterwards
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #1553 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   28.99%   28.99%           
=======================================
  Files          32       32           
  Lines        1452     1452           
  Branches      197      197           
=======================================
  Hits          421      421           
  Misses       1029     1029           
  Partials        2        2
Impacted Files Coverage Δ
packages/core/directives/map.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa80b87...00b46e5. Read the comment docs.

@sebholstein sebholstein merged commit 0e8f1ab into sebholstein:master Nov 30, 2018
@sebholstein
Copy link
Owner

thanks!

@fredgate
Copy link

Great. But this is a blocking bug. It will be nice to release a new version ?

@john-hi
Copy link

john-hi commented Mar 7, 2019

new google.maps.LatLngBounds(); creates strange bounds (180,1; -180,-1) subsequent newBounds.union(bounds); doesn't mend situation and as result of union we have newBounds equaled (180,1; -180;-1). I don't think it is what we wanted.

Suggest use

var newBounds = new google.maps.LatLngBounds(
    { lat: bounds.south, lng: bounds.west },
    { lat: bounds.north, lng: bounds.east}
);
bounds = newBounds;

or even bounds = { ...bounds }; if we don't need LatLngBounds class functionality

@john-hi
Copy link

john-hi commented Mar 7, 2019

as I understand core functionality of project has been in wrong state more then five months. We should fix it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants