Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AgmMap): add area restriction option #1624

Merged
2 commits merged into from
May 31, 2019

Conversation

kamilchlebek
Copy link
Contributor

@kamilchlebek kamilchlebek commented Mar 28, 2019

Adds new option to map configuration: restriction

export interface MapRestriction {
  latLngBounds: LatLngBounds|LatLngBoundsLiteral;
  strictBounds?: boolean;
}

Notice: It requires google maps api at least v3.35.

Resolves: #1623

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #1624 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   33.25%   33.23%   -0.03%     
==========================================
  Files          37       37              
  Lines        1636     1637       +1     
  Branches      128      128              
==========================================
  Hits          544      544              
- Misses       1090     1091       +1     
  Partials        2        2
Impacted Files Coverage Δ
packages/core/services/google-maps-types.ts 0% <ø> (ø) ⬆️
packages/core/directives/map.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2f2dc...572be26. Read the comment docs.

@kamilchlebek
Copy link
Contributor Author

It there a possibility to have it merged soon?

@ghost
Copy link

ghost commented May 18, 2019

Hey, @kamilchlebek, SebastianM is the project creator and maintainer, and he's been away for a few months now. Can you please send your PR to our crowdsourced fork https://github.com/agm-preview/angular-google-maps ? That way users can start using your contribution. When SEbastian comes back, we'll send all our work back to him.

@ghost
Copy link

ghost commented May 30, 2019

hey, @kamilchlebek, would you mind updating your branch?

@kamilchlebek
Copy link
Contributor Author

I can see that there will be some progress in this repository ( https://github.com/agm-preview/angular-google-maps/issues/8 )? Is merge to agm-preview still required?

@ghost
Copy link

ghost commented May 30, 2019

no, agm-preview is going away, now that there are new active members of the core team

@jimmykane
Copy link

@doom777 do we expect to get the goodies from preview any time soon?

@ghost ghost merged commit 7201a75 into sebholstein:master May 31, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new configuration option: restriction
3 participants