Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polygon, polyline): add path change event #1643

Merged
1 commit merged into from May 30, 2019
Merged

feat(polygon, polyline): add path change event #1643

1 commit merged into from May 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2019

Adds the MVCArray type, and allow to bind to changes in the paths of
AgmPolygon and AgmPolyline

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #1643 into master will increase coverage by 2.6%.
The diff coverage is 67.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1643     +/-   ##
=========================================
+ Coverage   30.64%   33.25%   +2.6%     
=========================================
  Files          36       37      +1     
  Lines        1540     1636     +96     
  Branches      125      128      +3     
=========================================
+ Hits          472      544     +72     
- Misses       1066     1090     +24     
  Partials        2        2
Impacted Files Coverage Δ
packages/core/services/google-maps-types.ts 0% <ø> (ø) ⬆️
packages/core/directives/polygon.ts 53.94% <24%> (-1.94%) ⬇️
packages/core/directives/polyline.ts 49.41% <33.33%> (-1.23%) ⬇️
...ackages/core/services/managers/polyline-manager.ts 63.63% <44.44%> (-4.94%) ⬇️
packages/core/utils/mvcarray-utils.ts 86.95% <86.95%> (ø)
packages/core/services/managers/polygon-manager.ts 76.78% <87.09%> (+7.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca0194...d824427. Read the comment docs.

@ghost
Copy link
Author

ghost commented May 30, 2019

fix #823

Adds the MVCArray type, and allow to bind to changes in the paths of
AgmPolygon and AgmPolyline
@ghost ghost merged commit f9352a8 into sebholstein:master May 30, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants