Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geocoding Service #1694

Closed
ghost opened this issue Jul 23, 2019 · 5 comments
Closed

Geocoding Service #1694

ghost opened this issue Jul 23, 2019 · 5 comments
Labels
P4: nice to have type: feature-request

Comments

@ghost
Copy link

ghost commented Jul 23, 2019

Issue description
Provide a geocoding service which will provide lat/lngs for an address request.
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 1, 2019
feat(AgmGeocoder): add geocoder service
7c6993f 
- add geocoder service
- add interfaces to support geocoder request and response

implements sebholstein#1694
@DefJunx
Copy link
Contributor

DefJunx commented Oct 1, 2019

@doom777 i've done a very basic implementation of this, and I also still have to make test cases for it.

Before proceeding though, could you look at the commit and tell me if that's what you had in mind with this issue?

@ghost
Copy link
Author

ghost commented Oct 1, 2019

Looks good, just how are you preventing calls to geocode, before googleGeocoderInstance is instantiated?

@DefJunx
Copy link
Contributor

DefJunx commented Oct 1, 2019 •
edited

@doom777 I'm not right now, and that's clearly a problem. What would be a good preferred way to implement that?

EDIT: I have implemented a basic guard to check if the instance is defined or not.

DefJunx referenced this issue in DefJunx/angular-google-maps Oct 2, 2019
feat(AgmGeocoder): add geocoder service
bd0c532 
- add initial test implementation

implements SebastianM#1694
DefJunx referenced this issue in DefJunx/angular-google-maps Oct 2, 2019
feat(AgmGeocoder): add geocoder service
4aefe4f 
- Fix wrong geocodeMock jest function

implements SebastianM#1694
@ghost
Copy link
Author

ghost commented Oct 2, 2019

Usually the way we solve this is by storing a promise of a member, and not an instance. That way, all calls can be delayed until it's initialized.

DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 2, 2019
feat(AgmGeocoder): add geocoder service
31123b6 
- avoid method being called without google being initialized
- Add geocoder interface

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 2, 2019
feat(AgmGeocoder): add geocoder service
0d3d478 
- Changed geocoder service structure

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 2, 2019
feat(AgmGeocoder): add geocoder service
ef4615a 
- add geocoder object as private observable
to follow style of other services

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 2, 2019
feat(AgmGeocoder): add geocoder service
e640fb3 
- add test

implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 3, 2019
feat(AgmGeocoder): Implement Geocoding Service
b639f1d 
- refactor geocode method

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 3, 2019
feat(AgmGeocoder): Implement geocoding service
0acd207 
- Export Geocoder class

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 3, 2019
feat(AgmGeocoder): Implement Geocoding service
f786e2f 
- Change geocoder from observable to promise
- Fix enum to match Google

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 3, 2019
feat(AgmGeocoder): Implement Geocoding service
7aba28f 
- Fix tests
- Add failure test

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 9, 2019
feat(AgmGeocoder): Implement Geocoding service
c90930e 
- Remove unused methods from imports

Implements sebholstein#1694
@DefJunx DefJunx mentioned this issue Oct 11, 2019
Merged
@DefJunx
Copy link
Contributor

DefJunx commented Oct 11, 2019

@doom777 I think I'm finally done with this issue (#1743), and am somewhat satisfied about the result. Please let me know what you think about it, I'm definitely up for improvement and criticism.

DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
2826406 
- add geocoder service
- add interfaces to support geocoder request and response
- add test cases

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
fda0113 
- add geocoder service
- add interfaces to support geocoder request and response
- add test cases

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
6ee3de7 
- add geocoder service
- add interfaces to support geocoder request and response
- add test cases

Implements sebholstein#1694
DefJunx referenced this issue in DefJunx/angular-google-maps Oct 17, 2019
feat(AgmGeocoder): add geocoder service
c173b87 
- add initial test implementation

implements SebastianM#1694
DefJunx referenced this issue in DefJunx/angular-google-maps Oct 17, 2019
feat(AgmGeocoder): add geocoder service
00501da 
- Fix wrong geocodeMock jest function

implements SebastianM#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
8391090 
- avoid method being called without google being initialized
- Add geocoder interface

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
002c7e0 
- Changed geocoder service structure

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
f1b985c 
- add geocoder object as private observable
to follow style of other services

Implements sebholstein#1694
DefJunx pushed a commit to DefJunx/angular-google-maps that referenced this issue Oct 17, 2019
feat(AgmGeocoder): add geocoder service
70e252c 
- add test

implements sebholstein#1694
ghost pushed a commit that referenced this issue Oct 18, 2019
@doom777
feat(AgmGeocoder): add geocoder service and tests (#1743)
3549ccf 
- add geocoder service
- add interfaces to support geocoder request and response
- add test cases

Implements: #1694
@ghost ghost closed this as completed Oct 18, 2019
pertsenga pushed a commit to pertsenga/angular-google-maps that referenced this issue Nov 6, 2019
feat(AgmGeocoder): add geocoder service and tests (sebholstein#1743)
5706d9b 
- add geocoder service
- add interfaces to support geocoder request and response
- add test cases

Implements: sebholstein#1694
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4: nice to have type: feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DefJunx