Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AgmMap): respect disableDefaultUI #1709

Merged
merged 1 commit into from Aug 23, 2019
Merged

fix(AgmMap): respect disableDefaultUI #1709

merged 1 commit into from Aug 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2019

correctly disables streetViewControl and zoomControl when
disableDefaultUi is set to true

fixes: #933

correctly disables streetViewControl and zoomControl when
disableDefaultUi is set to true

fixes: #933
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #1709 into master will increase coverage by 7.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
+ Coverage   39.83%   47.25%   +7.42%     
==========================================
  Files          41       41              
  Lines        1805     1805              
  Branches      165      165              
==========================================
+ Hits          719      853     +134     
+ Misses       1083      949     -134     
  Partials        3        3
Impacted Files Coverage Δ
packages/core/directives/map.ts 64.4% <100%> (+64.4%) ⬆️
...kages/core/services/managers/data-layer-manager.ts 24.44% <0%> (+24.44%) ⬆️
...ckages/core/services/managers/kml-layer-manager.ts 42.85% <0%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44061e8...28f3f0f. Read the comment docs.

@msenosiain msenosiain merged commit b70cbbc into sebholstein:master Aug 23, 2019
@ghost ghost deleted the defaultui branch August 23, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disableDefaultUI & disableDoubleClickZoom do not work
1 participant